insberr/schedule-personalizer
1
0
Fork 0
Code Issues 18 Pull requests 7 Projects Releases 2 Packages Wiki Activity Actions

React Router #55

Merged
webmsgr merged 9 commits from v5-react-router into v5 2022-09-12 14:50:21 -07:00
Conversation 14 Commits 9 Files changed 19 +136 -103
webmsgr commented 2022-09-12 09:01:11 -07:00 (Migrated from github.com)
Copy link

replaces the old page system with react router

Known bugs:

  • Manual navigation to /setup errors when already setup Fixed in 602dda4
  • Manual dev term input doesn't work (I screwed up) Fixed in 8e27c31523
replaces the old page system with react router Known bugs: * ~Manual navigation to /setup errors when already setup~ Fixed in 602dda4 * ~Manual dev term input doesn't work (I screwed up)~ Fixed in 8e27c31523f25f403400a522eb000a1f4b8aebc5
lgtm-com[bot] commented 2022-09-12 09:06:06 -07:00 (Migrated from github.com)
Copy link

This pull request introduces 9 alerts when merging 5e5c666e46 into 4742ddab96 - view on LGTM.com

new alerts:

  • 9 for Unused variable, import, function or class
This pull request **introduces 9 alerts** when merging 5e5c666e461393244fe8bdc7de7a3e4f3d752645 into 4742ddab969deef34f5f3ca8512526b5cd565292 - [view on LGTM.com](https://lgtm.com/projects/g/insberr/schedule-personalizer/rev/pr-da0dd077f6582afad191f436add36c04c948f4b7) **new alerts:** * 9 for Unused variable, import, function or class
webmsgr commented 2022-09-12 09:06:59 -07:00 (Migrated from github.com)
Copy link

Think I figured out the issue, forgor react.suspense

Think I figured out the issue, forgor react.suspense
webmsgr commented 2022-09-12 09:16:33 -07:00 (Migrated from github.com)
Copy link

Does cloudflare route all unknown routes to index.html, there's a hack way to fix it if it doesn't but still.

Does cloudflare route all unknown routes to index.html, there's a hack way to fix it if it doesn't but still.
lgtm-com[bot] commented 2022-09-12 09:19:41 -07:00 (Migrated from github.com)
Copy link

This pull request introduces 8 alerts when merging 602dda4cdd into 4742ddab96 - view on LGTM.com

new alerts:

  • 8 for Unused variable, import, function or class
This pull request **introduces 8 alerts** when merging 602dda4cddb08cc41de283c4117d676ee7dfad6a into 4742ddab969deef34f5f3ca8512526b5cd565292 - [view on LGTM.com](https://lgtm.com/projects/g/insberr/schedule-personalizer/rev/pr-69b55b0a818bfeb7b10d463eabc19640ded9c426) **new alerts:** * 8 for Unused variable, import, function or class
webmsgr commented 2022-09-12 09:22:14 -07:00 (Migrated from github.com)
Copy link

Maybe a 404 page: https://reactrouter.com/en/main/getting-started/faq#how-do-i-add-a-no-match-404-route-in-react-router-v6

Maybe a 404 page: https://reactrouter.com/en/main/getting-started/faq#how-do-i-add-a-no-match-404-route-in-react-router-v6
cloudflare-workers-and-pages[bot] commented 2022-09-12 09:24:32 -07:00 (Migrated from github.com)
Copy link

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 8e27c31
Status: ✅  Deploy successful!
Preview URL: https://21db3951.schedule-personalizer.pages.dev
Branch Preview URL: https://v5-react-router.schedule-personalizer.pages.dev

View logs

## Deploying with &nbsp;<a href="https://pages.dev"><img alt="Cloudflare Pages" src="https://user-images.githubusercontent.com/23264/106598434-9e719e00-654f-11eb-9e59-6167043cfa01.png" width="16"></a> &nbsp;Cloudflare Pages <table><tr><td><strong>Latest commit:</strong> </td><td> <code>8e27c31</code> </td></tr> <tr><td><strong>Status:</strong></td><td>&nbsp;✅&nbsp; Deploy successful!</td></tr> <tr><td><strong>Preview URL:</strong></td><td> <a href='https://21db3951.schedule-personalizer.pages.dev'>https://21db3951.schedule-personalizer.pages.dev</a> </td></tr> <tr><td><strong>Branch Preview URL:</strong></td><td> <a href='https://v5-react-router.schedule-personalizer.pages.dev'>https://v5-react-router.schedule-personalizer.pages.dev</a> </td></tr> </table> [View logs](https://dash.cloudflare.com/?to=/:account/pages/view/schedule-personalizer/21db3951-585d-412b-be1b-9715d42fb9aa)
webmsgr commented 2022-09-12 09:43:03 -07:00 (Migrated from github.com)
Copy link

TODO: setup caching with the service worker.

TODO: setup caching with the service worker.
webmsgr commented 2022-09-12 11:19:39 -07:00 (Migrated from github.com)
Copy link

TODO: editor page integrate with react router

TODO: editor page integrate with react router
lgtm-com[bot] commented 2022-09-12 11:37:26 -07:00 (Migrated from github.com)
Copy link

This pull request introduces 8 alerts when merging fb44171cd0 into 4742ddab96 - view on LGTM.com

new alerts:

  • 8 for Unused variable, import, function or class
This pull request **introduces 8 alerts** when merging fb44171cd014f294664d4d167ef2534814718a7d into 4742ddab969deef34f5f3ca8512526b5cd565292 - [view on LGTM.com](https://lgtm.com/projects/g/insberr/schedule-personalizer/rev/pr-3593a446352cf9fbe1ac3084358a264d31eb5770) **new alerts:** * 8 for Unused variable, import, function or class
lgtm-com[bot] commented 2022-09-12 12:05:17 -07:00 (Migrated from github.com)
Copy link

This pull request introduces 8 alerts when merging 048fc0460c into 4742ddab96 - view on LGTM.com

new alerts:

  • 8 for Unused variable, import, function or class
This pull request **introduces 8 alerts** when merging 048fc0460c692e1a5324444102f733336a9db270 into 4742ddab969deef34f5f3ca8512526b5cd565292 - [view on LGTM.com](https://lgtm.com/projects/g/insberr/schedule-personalizer/rev/pr-74788eda2cfd07f7bed03022874b09e575793064) **new alerts:** * 8 for Unused variable, import, function or class
lgtm-com[bot] commented 2022-09-12 12:12:54 -07:00 (Migrated from github.com)
Copy link

This pull request introduces 8 alerts when merging 61c2819e82 into 4742ddab96 - view on LGTM.com

new alerts:

  • 8 for Unused variable, import, function or class
This pull request **introduces 8 alerts** when merging 61c2819e8224ebc1e0a17b92af0170de2c452a8f into 4742ddab969deef34f5f3ca8512526b5cd565292 - [view on LGTM.com](https://lgtm.com/projects/g/insberr/schedule-personalizer/rev/pr-e70759b364c982b818e651044e1772c2c26f430a) **new alerts:** * 8 for Unused variable, import, function or class
lgtm-com[bot] commented 2022-09-12 12:15:48 -07:00 (Migrated from github.com)
Copy link

This pull request introduces 8 alerts when merging 0b4e2d3612 into 4742ddab96 - view on LGTM.com

new alerts:

  • 8 for Unused variable, import, function or class
This pull request **introduces 8 alerts** when merging 0b4e2d361205c33ce8375eaa0353109f0494308d into 4742ddab969deef34f5f3ca8512526b5cd565292 - [view on LGTM.com](https://lgtm.com/projects/g/insberr/schedule-personalizer/rev/pr-23bbfda2826b78865e8f550842325e1646958acf) **new alerts:** * 8 for Unused variable, import, function or class
lgtm-com[bot] commented 2022-09-12 12:35:59 -07:00 (Migrated from github.com)
Copy link

This pull request introduces 9 alerts when merging 8e27c31523 into 4742ddab96 - view on LGTM.com

new alerts:

  • 9 for Unused variable, import, function or class
This pull request **introduces 9 alerts** when merging 8e27c31523f25f403400a522eb000a1f4b8aebc5 into 4742ddab969deef34f5f3ca8512526b5cd565292 - [view on LGTM.com](https://lgtm.com/projects/g/insberr/schedule-personalizer/rev/pr-ab5825e0d39379fca500c1542aa99f0785f8cded) **new alerts:** * 9 for Unused variable, import, function or class
insberr approved these changes 2022-09-12 14:50:09 -07:00
insberr left a comment
Owner
Copy link

looks good

looks good
Sign in to join this conversation.
Reviewers
No reviewers
insberr
Labels
Clear labels   
annoying

This is an annoyance

  
bug

Something isn't working

  
cantfix

cant fix because of some external problem

  
config

   
dependencies

Pull requests that update a dependency file

  
do soon

Do these ASAP

  
documentation

Improvements or additions to documentation

  
duplicate

This issue or pull request already exists

  
enhancement

New feature or request

  
future

   
good first issue

Good for newcomers

  
help wanted

Extra attention is needed

  
internal

Code format, organization, etc.

  
invalid

This doesn't seem right

  
pain

   
question

Further information is requested

  
style

CSS style or frontend layout/design

  
todo

Feature needs to be added

  
wontfix

This will not be worked on

No labels
annoying
bug
cantfix
config
dependencies
do soon
documentation
duplicate
enhancement
future
good first issue
help wanted
internal
invalid
pain
question
style
todo
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
insberr/schedule-personalizer!55
No description provided.